Repository navigation
feat(stovepipe): record analysis and repair history - #995
Merged
Merged
Conversation
Summary: ## Why? Stovepipe request history does not show when terminal issue analysis or reconciliation finishes, or whether repair work was submitted, skipped, or abandoned. ## What? - Add `build_analysis_completed`, `issues_reconciled`, `fix_submitted`, `fix_submission_skipped`, and `fix_submission_abandoned`; preserve the existing `issue_tracking_abandoned` event and recovery behavior. - Retain history idempotently and repair missing entries from durable fix associations and completed reconciliation checkpoints. Register fix recovery without submitting more repair work or changing validation outcomes. - Cover retries, closure suppression, uncertain external acceptance, long fix IDs, and server registration. Test Plan: For local exercise, run `make local-stovepipe-start`. The reference service uses no-op issue detection and repair execution; external repair acceptance requires a deployment-supplied executor and was not exercised manually.
mnoah1
marked this pull request as ready for review
October 30, 2026 18:43
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 30, 2026 18:43
mnoah1
enabled auto-merge
October 30, 2026 19:41
roychying
reviewed
Nov 2, 2026
roychying
requested changes
Nov 2, 2026
roychying
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Stovepipe request history does not show when terminal issue analysis or reconciliation finishes, or whether repair work was submitted, skipped, or abandoned.
What?
build_analysis_completed,issues_reconciled,fix_submitted,fix_submission_skipped, andfix_submission_abandoned; preserve the existingissue_tracking_abandonedevent and recovery behavior.Test Plan
For local exercise, run
make local-stovepipe-start. The reference service uses no-op issue detection and repair execution; external repair acceptance requires a deployment-supplied executor and was not exercised manually.Passed eight focused Bazel suites covering build analysis, fix submission, issue tracking, request-log materialization, entities, build signals, recording, and server registration; formatting, lint, tidy, and Gazelle checks also passed.
The full repository build and all 184 unit/web test targets also passed.
Review revision: seven focused Bazel suites passed, including the build-analysis pipeline; formatting, lint, tidy, and Gazelle checks passed. Regression cases cover held passes, history and publication failures, changed counts, concurrent completion, uncertain writes, and identity conflicts.
Revert Plan
Revert this PR; no schema changes are required.